Repository navigation
x/sqlbuilder/upserter: add PredicateClause to restrict updates - #48
Merged
Merged
Conversation
AlexisMontagne
requested review from
karitham and
xgoffin
and removed request for
a team
October 21, 2026 18:15
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-review
labels
Allows callers to only update an existing row when a predicate holds, e.g. for optimistic concurrency checks. Rows that do not exist yet are still inserted. Backed by a new Where on OnConflictClause, rendered as DO UPDATE SET ... WHERE.
AlexisMontagne
force-pushed
the
am-predicated-upserter
branch
from
October 21, 2026 18:24
6b01d83 to
ad66a08
Compare
FlorianRichardUPF
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows callers to only update an existing row when a predicate holds, e.g. for optimistic concurrency checks. Rows that do not exist yet are still inserted.
This adds a
Wheretosqlbuilder.OnConflictClause, rendered asDO UPDATE SET ... WHERE, and exposes it on the upserter throughStatement.PredicateClause. TheWhereis ignored forDO NOTHING.What are the observable changes?
Feature:
upserter.Statementaccepts aPredicateClause. With a key constrained upsert, the generated statement becomes:Good PR checklist
Additional Notes
Rebased on
masterafterExcludedlanded; the only conflict was ininsert_statement_test.go, where both sides added independent test cases and both were kept.